fix(stdlibs/io): handle potential overflow in NewSectionReader
#1905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`NewSectionReader` sets `remaining` to `maxInt64` (i.e `1<<63 - 1`) in case of overflow, but it remained unused. `SectionReader.limit` is always set to `n+off`. Utilize `remaining` to handle overflow.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1905 +/- ##
=======================================
Coverage 47.74% 47.74%
=======================================
Files 393 393
Lines 61637 61637
=======================================
Hits 29430 29430
Misses 29736 29736
Partials 2471 2471 ☔ View full report in Codecov by Sentry. |
|
btw, this is tackled also in https://github.com/gnolang/gno/pull/1702/files#diff-e1009a028298b37b0e8ac2b58a5df9a2021cc1e7a3ce7a38872bf2f3b8cc49f3, happy to merge this first though |
thehowl
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NewSectionReadersetsremainingtomaxInt64(i.e1<<63 - 1) in case of overflow, but it remained unused.SectionReader.limitis always set ton+off. Utilizeremainingto handle overflow.Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description