Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use docker buildx on ci to support multiple arch #1912

Merged
merged 2 commits into from
Apr 11, 2024
Merged

fix: use docker buildx on ci to support multiple arch #1912

merged 2 commits into from
Apr 11, 2024

Conversation

gfanton
Copy link
Member

@gfanton gfanton commented Apr 10, 2024

Cleanup and upgrade CI docker build jobs to use Docker Buildx for multi-architecture support

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@gfanton
fix: use docker buildx on ci to support multiple platforms
b4654a4 
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
@gfanton
chore: remove useless CGO_ENABLED env
3461319 
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
@gfanton gfanton self-assigned this Apr 10, 2024
@gfanton gfanton requested review from moul and a team as code owners April 10, 2024 17:16
zivkovicmilos
zivkovicmilos approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix 🙏

@thehowl thehowl merged commit f962c71 into gnolang:master Apr 11, 2024
71 of 75 checks passed
@thehowl thehowl mentioned this pull request Apr 11, 2024
Open
3 tasks
gfanton added a commit that referenced this pull request Apr 11, 2024
@gfanton
Revert "ci: use docker buildx to support multiple arch (#1912)"
ec716cf 
This reverts commit f962c71.
@gfanton gfanton mentioned this pull request Apr 11, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zivkovicmilos zivkovicmilos zivkovicmilos approved these changes

@harry-hov harry-hov harry-hov approved these changes

@moul moul Awaiting requested review from moul moul is a code owner

@albttx albttx Awaiting requested review from albttx

Assignees

@gfanton gfanton

Labels
None yet
Projects
💪 Bounties & Worx
Status: Done
🧐 Review Meeting
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gfanton @zivkovicmilos @harry-hov @thehowl