feat: slightly improve node log lines #1916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
📦 🌐 tendermint v2
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1916 +/- ##
==========================================
+ Coverage 45.10% 47.77% +2.67%
==========================================
Files 464 393 -71
Lines 68000 61630 -6370
==========================================
- Hits 30669 29443 -1226
+ Misses 34759 29717 -5042
+ Partials 2572 2470 -102 ☔ View full report in Codecov by Sentry. |
gfanton
approved these changes
Apr 15, 2024
omarsy
pushed a commit
to TERITORI/gno
that referenced
this pull request
Apr 16, 2024
## Description This PR improves the log lines produced by the node binary. Before:  After:  <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
thehowl
reviewed
Apr 17, 2024
| ____ _____ ____ / /___ _____ ____/ / | ||
| / __ %c/ __ \/ __ \/ / __ %c/ __ \/ __ / | ||
| / /_/ / / / / /_/ / / /_/ / / / / /_/ / | ||
| \__, /_/ /_/\____/_/\__,_/_/ /_/\__,_/ |
There was a problem hiding this comment.
nit picking, but...
doesn't match my water bottle because that one says gno.land (emphasis on the full stop), pls fix 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the log lines produced by the node binary.
Before:
After:
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description