fix: remove empty timestamp from the tx signature payload

[zivkovicmilos]

Description

This PR closes #810

I've dropped the unused Timestamp field from the SignDoc, which forced all clients that generate tx signatures outside of the gno repo to initialize it to an empty UTC timestamp value (ex. Adena, tm2-js-client...)

BREAKING CHANGE: all clients that generate transaction signatures without using the provided Go methods in this repository need to update their source code to remove the Timestamp field. (@dongwon8247 @jefft0)

I've also provided error handling for generating these signature bytes, which weren't present before.

Contributors' checklist...

• Added new tests, or not needed, or not feasible
• Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
• Updated the official documentation or not needed
• No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
• Added references to related issues and PRs
• Provided any useful hints for running manual tests
• Added new benchmarks to generated graphs, if any. More info here.

[codecov]

Codecov Report

Attention: Patch coverage is 70.14925% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 46.67%. Comparing base (7bf662a) to head (11ad828).

Files	Patch %	Lines
tm2/pkg/std/tx.go	0.00%	9 Missing ⚠️
tm2/pkg/std/doc.go	57.14%	2 Missing and 1 partial ⚠️
gno.land/pkg/gnoclient/signer.go	33.33%	1 Missing and 1 partial ⚠️
tm2/pkg/crypto/keys/client/sign.go	77.77%	1 Missing and 1 partial ⚠️
tm2/pkg/sdk/auth/ante.go	84.61%	1 Missing and 1 partial ⚠️
tm2/pkg/std/utils.go	50.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1939      +/-   ##
==========================================
+ Coverage   46.64%   46.67%   +0.02%     
==========================================
  Files         492      492              
  Lines       69624    69657      +33     
==========================================
+ Hits        32476    32510      +34     
+ Misses      34442    34435       -7     
- Partials     2706     2712       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jefft0]

Hi @zivkovicmilos . Thanks for the head's up. Gno Native Kit relies on gnoclient to sign. Is this signing code affected by this PR?

[zivkovicmilos]

Hi @zivkovicmilos . Thanks for the head's up. Gno Native Kit relies on gnoclient to sign. Is this signing code affected by this PR?

If you're using the provided Go signing methods (from the repo) there is no action needed on your part -- a change is required only for non-Go clients (JS / TS, Rust...).

The signing code you've linked is already good to go (I've updated the gnoclient signer in this PR) 👌

[zivkovicmilos]

@jinoosss @dongwon8247
Let's coordinate an Adena + tm2-js-client release before merging this out for the Portal Loop

[moul]

I believed that having this field could be beneficial. If initializing an empty time field is complex, why not make it nullable? Are there any examples of using this field where it's not empty?

[jinoosss]

@zivkovicmilos
Adena only needs to follow the tm2-js-client version. (using only the signature of tm2-js-client)

[zivkovicmilos]

I believed that having this field could be beneficial. If initializing an empty time field is complex, why not make it nullable? Are there any examples of using this field where it's not empty?

The transaction timestamp can never be set with the current way the transactions are structured and parsed -- they don't have a timestamp field like in Ethereum (which doesn't go into the signature bytes). Ethereum transactions signatures are just signed RLP encodings (Ethereum encoding standard) of the following data points: nonce, gas price, gas limit, to, value, data, with additional things like gas fee info being tacked on as EIPs are enabled ("legacy" and "non-legacy" transactions)

Making the field nullable now introduces another logic block, where the node would need to reconstruct 2 tx signature bytes (one with an empty timestamp, the other without a timestamp) to verify that a signature is valid / invalid (and one of these will always be invalid). This signature bytes moment needs to be deterministic and simple on both the client (generating the sig) and the node (verifying the sig), to avoid overhead

[gfanton]

from the review meeting: good to go 👍