fix: move gnofaucet to contribs
#1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
📦 ⛰️ gno.land
|
@gfanton Would appreciate the help with the |
gfanton
force-pushed
the
feat/move-gnofaucet
branch
from
5e267d4
to
6a0bceb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1955 +/- ##
==========================================
- Coverage 47.78% 45.16% -2.62%
==========================================
Files 393 465 +72
Lines 61608 68087 +6479
==========================================
+ Hits 29437 30752 +1315
- Misses 29701 34758 +5057
- Partials 2470 2577 +107 ☔ View full report in Codecov by Sentry. |
|
I will improve and revise the entire Dockerfile later. For now, it seems satisfactory with minimal changes. |
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
gfanton
force-pushed
the
feat/move-gnofaucet
branch
from
6a0bceb
to
971e5b6
Compare
gfanton
approved these changes
Apr 19, 2024
thehowl
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
LGTM, I was reading through the docs and saw that there is never a command which references how to install the faucet itself.
So, good, maybe @leohhhn can add that later to the related docs pages for gnofaucet.
Just one note about the CI, then we should be good to go.
7 tasks
omarsy
pushed a commit
to TERITORI/gno
that referenced
this pull request
Apr 21, 2024
## Description This PR moves the `gnofaucet` codebase from `gno.land/cmd/gnofaucet` to `./contribs/gnofaucet`, as this is causing API shenanigans when any `gno` API used by the `gnolang/faucet` library is changed. Thank you @gfanton for resolving the Docker funny business 🙏 <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> --------- Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com> Co-authored-by: gfanton <8671905+gfanton@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the
gnofaucetcodebase fromgno.land/cmd/gnofaucetto./contribs/gnofaucet, as this is causing API shenanigans when anygnoAPI used by thegnolang/faucetlibrary is changed.Thank you @gfanton for resolving the Docker funny business 🙏
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description