fix(gnovm): revert "top sort var/const globals (#1854)" #1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3b95486.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1956 +/- ##
==========================================
+ Coverage 45.18% 47.78% +2.59%
==========================================
Files 465 393 -72
Lines 68081 61602 -6479
==========================================
- Hits 30763 29437 -1326
+ Misses 34742 29695 -5047
+ Partials 2576 2470 -106 ☔ View full report in Codecov by Sentry. |
moul
approved these changes
Apr 21, 2024
harry-hov
approved these changes
Apr 21, 2024
|
jae asked me to undo the merge in DMs, so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per discussion with @jaekwon; see #1854 (comment)