Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gnokey sign should sign transactions #1976

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

zivkovicmilos
Copy link
Member

Description

This PR fixes the signing logic of gnokey sign, to now actually sign a transaction if the user's signature is missing.
Additionally, it cleans up the code, and adds coverage tests.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@zivkovicmilos zivkovicmilos added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Apr 24, 2024
@zivkovicmilos zivkovicmilos self-assigned this Apr 24, 2024
@zivkovicmilos zivkovicmilos requested review from jaekwon, moul, a team and piux2 as code owners April 24, 2024 09:47
@zivkovicmilos zivkovicmilos changed the title fix: gnokey sign signs transactions fix: gnokey sign should sign transactions Apr 24, 2024
@github-actions github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label Apr 24, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.24%. Comparing base (2f72f84) to head (4260cea).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1976      +/-   ##
==========================================
+ Coverage   45.63%   48.24%   +2.60%     
==========================================
  Files         480      408      -72     
  Lines       68817    62260    -6557     
==========================================
- Hits        31408    30039    -1369     
+ Misses      34795    29717    -5078     
+ Partials     2614     2504     -110     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zivkovicmilos zivkovicmilos marked this pull request as draft April 24, 2024 09:58
@zivkovicmilos zivkovicmilos marked this pull request as ready for review April 24, 2024 10:08
@zivkovicmilos zivkovicmilos merged commit b4bf514 into gnolang:master Apr 24, 2024
72 of 75 checks passed
@zivkovicmilos zivkovicmilos deleted the fix/gnokey-sign branch April 24, 2024 17:05
thehowl added a commit that referenced this pull request Jun 6, 2024
This matches `gnokey sign`'s behaviour to the updated version from
#1976. I've manually tested this on a local node, and it works.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants