Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep data as default gnohome keybase db #1984

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

gfanton
Copy link
Member

@gfanton gfanton commented Apr 25, 2024

following #1944

The $GNOHOME/data directory has been moved to the $GNOHOME/db directory, which can lead to confusion as no proper migration has been set up. This PR reverts the data folder back to its original location for GNOHOME.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@gfanton gfanton self-assigned this Apr 25, 2024
@gfanton gfanton requested review from jaekwon, moul and a team as code owners April 25, 2024 15:12
@github-actions github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label Apr 25, 2024
@zivkovicmilos zivkovicmilos added the hotfix Major bug fix that should be merged ASAP label Apr 25, 2024
@zivkovicmilos
Copy link
Member

@gfanton please check mod tidy for some reason

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
@zivkovicmilos
Copy link
Member

Confirmed works ✅

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 46.25%. Comparing base (ee9e2e2) to head (aa161c2).

Files Patch % Lines
tm2/pkg/crypto/keys/utils.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1984      +/-   ##
==========================================
- Coverage   48.28%   46.25%   -2.03%     
==========================================
  Files         409      483      +74     
  Lines       62225    68837    +6612     
==========================================
+ Hits        30045    31842    +1797     
- Misses      29669    34368    +4699     
- Partials     2511     2627     +116     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gfanton gfanton merged commit 6c8f455 into gnolang:master Apr 25, 2024
190 checks passed
@gfanton gfanton deleted the fix/home-keybase-dir branch April 25, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix Major bug fix that should be merged ASAP 📦 🌐 tendermint v2 Issues or PRs tm2 related
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants