chore: split biggest unit test suites in Makefile + CI #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the pros:
* it makes things faster to run on CI, and potentially faster locally when using
`make -j`.
* make logs more readable on failing CI jobs (GitHub is not very easy to use for
very long CI logs).
* allow retrying a specific job on CI instead of running everything.
* give a feeling on the impact of a recent change based on if everything is red VS
only one suite is red.
the bad:
* the Makefile starts being complex, I think we'll need a rewrite in a near future.
$ go test -v ./pkgs/... | grep -E '^ok'| awk '{print $3 " " $2}' | sort -nr | head
466.970s github.com/gnolang/gno/pkgs/amino
129.709s github.com/gnolang/gno/pkgs/bft/consensus
42.514s github.com/gnolang/gno/pkgs/bft/wal
23.129s github.com/gnolang/gno/pkgs/iavl
11.344s github.com/gnolang/gno/pkgs/crypto/keys
9.834s github.com/gnolang/gno/pkgs/bft/rpc/lib/client
8.694s github.com/gnolang/gno/pkgs/bft/mempool
8.211s github.com/gnolang/gno/pkgs/bft/privval
8.034s github.com/gnolang/gno/pkgs/bft/rpc/lib
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the pros:
make -j.very long CI logs).
only one suite is red.
the bad:
the Makefile starts being complex, I think we'll need a rewrite in a near future.
$ go test -v ./pkgs/... | grep -E '^ok'| awk '{print $3 " " $2}' | sort -nr | head
466.970s github.com/gnolang/gno/pkgs/amino
129.709s github.com/gnolang/gno/pkgs/bft/consensus
42.514s github.com/gnolang/gno/pkgs/bft/wal
23.129s github.com/gnolang/gno/pkgs/iavl
11.344s github.com/gnolang/gno/pkgs/crypto/keys
9.834s github.com/gnolang/gno/pkgs/bft/rpc/lib/client
8.694s github.com/gnolang/gno/pkgs/bft/mempool
8.211s github.com/gnolang/gno/pkgs/bft/privval
8.034s github.com/gnolang/gno/pkgs/bft/rpc/lib