chore(ci): test start.sh for portal-loop #2064
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2064 +/- ##
==========================================
- Coverage 49.09% 49.08% -0.02%
==========================================
Files 576 576
Lines 77806 77806
==========================================
- Hits 38202 38192 -10
- Misses 36510 36519 +9
- Partials 3094 3095 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
review is ready @zivkovicmilos :) Full testing of portal loop :) |
|
Thanks @moul for review, everything is updated + |
| @@ -1,13 +1,15 @@ | |||
| name: portal-loop | |||
|
|
|||
| on: | |||
| pull_request: {} | |||
There was a problem hiding this comment.
Can we make sure this only runs for master pushes? Or do you think it makes more sense on each PR, given we can always create a tag (release) from a random branch
|
|
||
| - name: "Buid new gnolang/gno image" | ||
| run: | | ||
| docker build -t ghcr.io/gnolang/gno -f Dockerfile.gnoland.release . |
There was a problem hiding this comment.
I think we swapped the name from gnolang/gno to gnolang/gnoland for the chain binary
| @@ -46,3 +48,57 @@ jobs: | |||
| push: ${{ github.event_name != 'pull_request' }} | |||
| tags: ${{ steps.meta.outputs.tags }} | |||
| labels: ${{ steps.meta.outputs.labels }} | |||
|
|
|||
| test-portal-loop-docker-compose: | |||
There was a problem hiding this comment.
Dumb question, but do we need to close the containers somehow in the CI?
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description