Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: value decl loop #2074

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

fix: value decl loop #2074

wants to merge 8 commits into from

Conversation

petar-dambovaliev
Copy link
Contributor

@petar-dambovaliev petar-dambovaliev commented May 11, 2024

fixes this by splitting value declarations with multiple values into single declarations with a single value.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label May 11, 2024
Copy link

codecov bot commented May 11, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 49.00%. Comparing base (7d939a0) to head (c7cf53c).

Files Patch % Lines
gnovm/pkg/gnolang/preprocess.go 40.00% 17 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2074      +/-   ##
==========================================
- Coverage   49.01%   49.00%   -0.02%     
==========================================
  Files         576      576              
  Lines       77604    77617      +13     
==========================================
- Hits        38040    38037       -3     
- Misses      36481    36498      +17     
+ Partials     3083     3082       -1     
Flag Coverage Δ
contribs/gnodev 24.14% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (-0.86%) ⬇️
contribs/gnokeykc 0.00% <ø> (ø)
contribs/gnomd 0.00% <ø> (ø)
gno.land 61.69% <ø> (ø)
gnovm 41.94% <40.00%> (+<0.01%) ⬆️
misc/genproto 0.00% <ø> (ø)
misc/logos 17.68% <ø> (+0.30%) ⬆️
misc/loop 0.00% <ø> (ø)
tm2 54.58% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label May 11, 2024
@petar-dambovaliev petar-dambovaliev marked this pull request as ready for review May 12, 2024 11:20
tm2/pkg/crypto/bip39/bip39.go Outdated Show resolved Hide resolved
gnovm/pkg/gnolang/preprocess.go Outdated Show resolved Hide resolved
.github/golangci.yml Outdated Show resolved Hide resolved
@zivkovicmilos
Copy link
Member

@petar-dambovaliev
Can you please pull in the latest master changes? 🙏
We've overhauled the CI, so it should be much quicker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

bug: var declaration definition loop
3 participants