-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gnofaucet): add a captcha #242
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for this PR, it will be useful
can you address my few change requests?
i'm modifying things as your request.
|
👍 👍 👍
Up to you, but would be even better in the backend part of the faucet I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes; here are new requests
waiting for your aweeeesome review 😄 |
everything looks good now, I'll merge it soon, I need to fix the genesis first. |
…tion argument('captcha')
remove unused code Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
… secret from command line
I’ve reverted your last commit that was unrelated with the PR and merged the current state To avoid that I revert your commits, please start using branches instead of « master » on your fork Thank you |
Added Google reCaptcha v2 to prevent Faucet abuse