Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gnofaucet): add a captcha #242

Merged
merged 11 commits into from
Jun 20, 2022
Merged

feat(gnofaucet): add a captcha #242

merged 11 commits into from
Jun 20, 2022

Conversation

r3v4s
Copy link
Contributor

@r3v4s r3v4s commented Jun 9, 2022

image

Added Google reCaptcha v2 to prevent Faucet abuse

cmd/gnofaucet/gnofaucet.go Outdated Show resolved Hide resolved
Copy link
Member

@moul moul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for this PR, it will be useful

can you address my few change requests?

@r3v4s
Copy link
Contributor Author

r3v4s commented Jun 10, 2022

thank you for this PR, it will be useful

can you address my few change requests?

i'm modifying things as your request.
additionally do you think implementing (wallet) address verification in facuet.html gonna be useful?
if it is, what about using regex to verify with below conditions

  1. address has length of 40
  2. address starts with 'g1'

@moul
Copy link
Member

moul commented Jun 10, 2022

i'm modifying things as your request.

👍 👍 👍

additionally do you think implementing (wallet) address verification in facuet.html gonna be useful? if it is, what about using regex to verify with below conditions

Up to you, but would be even better in the backend part of the faucet I think.

cmd/gnofaucet/gnofaucet.go Outdated Show resolved Hide resolved
cmd/gnofaucet/gnofaucet.go Outdated Show resolved Hide resolved
cmd/gnofaucet/gnofaucet.go Outdated Show resolved Hide resolved
cmd/gnofaucet/gnofaucet.go Outdated Show resolved Hide resolved
gnoland/website/main.go Outdated Show resolved Hide resolved
Copy link
Member

@moul moul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes; here are new requests

@moul moul changed the title captcha for faucet feat(gnofaucet): add a captcha Jun 10, 2022
@r3v4s
Copy link
Contributor Author

r3v4s commented Jun 10, 2022

Thank you for the changes; here are new requests

waiting for your aweeeesome review 😄

cmd/gnofaucet/gnofaucet.go Outdated Show resolved Hide resolved
cmd/gnofaucet/gnofaucet.go Outdated Show resolved Hide resolved
cmd/gnofaucet/gnofaucet.go Outdated Show resolved Hide resolved
@moul
Copy link
Member

moul commented Jun 11, 2022

everything looks good now, I'll merge it soon, I need to fix the genesis first.

@moul moul merged commit dfa59dd into gnolang:master Jun 20, 2022
@moul
Copy link
Member

moul commented Jun 20, 2022

I’ve reverted your last commit that was unrelated with the PR and merged the current state

To avoid that I revert your commits, please start using branches instead of « master » on your fork

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants