feat(examples): a shifumi (rock, paper, scissors) smart contract #2629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A very simple game as a smart contract. It's possible to play against yourself, or another opponent. UI could be improved. No provision against cheating, no gain or automatic action. Related to gnolang#611.
mvertes
requested review from
jaekwon and
ltzmaxwell
and removed request for
a team
github-actions
bot
added
the
🧾 package/realm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2629 +/- ##
==========================================
- Coverage 54.99% 54.99% -0.01%
==========================================
Files 595 595
Lines 79775 79775
==========================================
- Hits 43872 43871 -1
- Misses 32581 32584 +3
+ Partials 3322 3320 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
thehowl
approved these changes
Jul 29, 2024
| move1, move2 int // can be empty, rock, paper, or scissors | ||
| } | ||
|
|
||
| var games = []*game{} |
There was a problem hiding this comment.
avl.Tree for scalability? can use seqid to have a compatible index
then the Render() page could render the, say, last 100 games.
| return output | ||
| } | ||
|
|
||
| func short(addr std.Address) string { |
There was a problem hiding this comment.
maybe use r/demo/users to resolve to a "shortname", but use the long address by default?
Comment on lines
+60
to
+67
| games = append(games, &game{player1: std.GetOrigCaller(), player2: player}) | ||
| return len(games) - 1 | ||
| } | ||
|
|
||
| // Play executes a move for the game at index idx, where move can be: | ||
| // 1 (rock), 2 (paper), 3 (scissors). | ||
| func Play(idx, move int) { | ||
| if err := games[idx].play(std.GetOrigCaller(), move); err != nil { |
There was a problem hiding this comment.
s/GetOrigCaller/PrevRealm().Addr()/g
otherwise, users can be impersonated by realms :)
Comment on lines
+79
to
+80
| * [NewGame](r/demo/games/shifumi?help&__func=NewGame) opponentAddress | ||
| * [Play](r/demo/games/shifumi?help&__func=Play) gameIndex move (1=rock, 2=paper, 3=scissors) |
There was a problem hiding this comment.
Suggested change
| * [NewGame](r/demo/games/shifumi?help&__func=NewGame) opponentAddress | |
| * [Play](r/demo/games/shifumi?help&__func=Play) gameIndex move (1=rock, 2=paper, 3=scissors) | |
| * [NewGame](shifumi?help&__func=NewGame) opponentAddress | |
| * [Play](shifumi?help&__func=Play) gameIndex move (1=rock, 2=paper, 3=scissors) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very simple game as a smart contract. It's possible to play against yourself, or another opponent. UI could be improved.
No provision against cheating, no gain or automatic action.
Related to #611.
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description