Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed gnokey add public key failure #264

Merged
merged 1 commit into from
Jun 24, 2022
Merged

Fixed gnokey add public key failure #264

merged 1 commit into from
Jun 24, 2022

Conversation

piux2
Copy link
Contributor

@piux2 piux2 commented Jun 24, 2022 •
edited

Fixed issue gnokey add can't add pubkeys #241

  • Updated package github.com/btcsuite/btcd/btcutil
  • Updated gno/pkgs/bech32/bech32.go
  • Added bech32 encode and decode testing cases in gno/pkgs/bech32/bech32_test.go
  • Added testing cases for importing public key and importing private key from recovery mnemonic in gno/pkgs/crypto/keys/client/add_test.go

moul
moul approved these changes Jun 24, 2022
View reviewed changes
Copy link
Member

@moul moul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@moul moul merged commit 26054dd into gnolang:master Jun 24, 2022
@moul moul mentioned this pull request Jun 24, 2022
Closed
@moul moul added this to the 🏗2️⃣ test2.gno.land milestone Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moul moul moul approved these changes

Assignees

@piux2 piux2

Labels
None yet
Projects
🚀 The Launch
Archived in project
Milestone
🏗2️⃣ test2.gno.land
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@piux2 @moul