WIP: Fix mempool PostCheck error bug #290
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PostCheck has a design flaw:
A checktx transaction that passes in the app's checktx state but fails postcheck would still increment the caller's sequence in the app's checktx state, causing an unexpected signature error even for subsequent txs by the same caller, until the next block (which clears the mempool).
The best solution that simplifies Tendermint is the one that moves this check constraint to the app itself, as implemented here.