fix(bft/rpc): check http status code #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change improves the error handling of rpc clients. Previously, the client tried to unmarshal the response body whatever the returned status code. This typically outputs errors like `invalid character '<' looking for beginning of value` because the body format is HTML and not JSON, and this kind of error is difficult to interpret for the end user. Now, if the status code is not between 200 and 299, the client doesn't try to unmarshal the response body and directly returns an error `server at '<ADDRESS>' returned <ERROR_STATUS>`.
moul
approved these changes
Oct 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves the error handling of rpc clients.
Previously, the client tried to unmarshal the response body whatever the returned status code. This typically outputs errors like
invalid character '<' looking for beginning of valuebecause the body format is HTML and not JSON. This kind of error is difficult to interpret for the end user, this was mentioned for instance in this issue #329 (comment).Now, if the status code is not between 200 and 299, the client doesn't try to unmarshal the response body and directly returns an error
server at '<ADDRESS>' returned <ERROR_STATUS>.