Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable auto precompile on gnodev test #359

Merged
merged 2 commits into from
Oct 19, 2022

Conversation

moul
Copy link
Member

@moul moul commented Oct 19, 2022

we should find a reliable way to re-enable it because it brings more useful
warnings for contracts developers.

but the current implementation is not reliable because it won't automatically
precompile imported packages.

and if the imported package is withing ~/go/mod/pkg, it's read-only. So we
also need to make it working in memory.

Signed-off-by: Manfred Touron 94029+moul@users.noreply.github.com

Fixes xplrz/gnoland-workshop#6

we should find a reliable way to re-enable it because it brings more useful
warnings for contracts developers.

but the current implementation is not reliable because it won't automatically
precompile imported packages.

and if the imported package is withing ~/go/mod/pkg, it's read-only. So we
also need to make it working in memory.

Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul moul force-pushed the dev/moul/disable-auto-precompile-on-testing branch from 795680c to 4cda9e6 Compare October 19, 2022 09:53
@moul moul marked this pull request as ready for review October 19, 2022 09:59
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul moul merged commit 9cc1bdc into gnolang:master Oct 19, 2022
@moul moul deleted the dev/moul/disable-auto-precompile-on-testing branch October 19, 2022 14:21
@moul moul added this to the 🏗3️⃣ test3.gno.land milestone Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

no Go files in....
1 participant