feat: implement grc721 #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add package `p/demo/grc/grc721` implementing igrc721.gno Signed-off-by: Hariom Verma <hariom.verma@tendermint.com>
Add tests for `p/demo/grc/grc721` methods. Signed-off-by: Hariom Verma <hariom.verma@tendermint.com>
harry-hov
force-pushed
the
hariom/grc721
branch
from
6d052a7
to
dea211e
Compare
Signed-off-by: Hariom Verma <hariom.verma@tendermint.com>
Signed-off-by: Hariom Verma <hariom.verma@tendermint.com>
harry-hov
force-pushed
the
hariom/grc721
branch
from
a78ff4b
to
2346689
Compare
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
moul
reviewed
Dec 12, 2022
zivkovicmilos
requested changes
Dec 27, 2022
There was a problem hiding this comment.
I've left a few comments that should be addressed before we proceed with adding the GRC721 contract.
The main concern I have is that this contract is not modeled after ERC721 (NFT) contracts, but is more similar to ERC20. There is no way to specify a content URI, which is what NFTs exclusively are for.
zivkovicmilos
approved these changes
Jan 9, 2023
|
Hey, this PR is ready, but since I merged #450, it will break. Please, can you update your code so it compiles with latest |
|
Hello @harry-hov, what an nice code!! Can it be replaced with |
|
Hey @r3v4-onbloc. It's not intentional. Just a blunder on my side. Since it's not used. It can be replaced with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
p/demo/grc/grc721andr/demo/foo721