Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add CODEOWNERS #448

Merged
merged 1 commit into from
Jan 9, 2023
Merged

chore: add CODEOWNERS #448

merged 1 commit into from
Jan 9, 2023

Conversation

moul
Copy link
Member

@moul moul commented Jan 4, 2023

With split by main project categories.

@moul moul self-assigned this Jan 4, 2023
zivkovicmilos
zivkovicmilos approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CODEOWNERS structure looks good to me 💯

Have you considered adding a repo-level security requirement that at least 1 or 2 codeowners need to approve a PR for it to be merged?

@moul moul merged commit 19cda00 into master Jan 9, 2023
@moul moul deleted the dev/moul/codeowners branch January 9, 2023 08:17
@moul moul added this to the 💡Someday/Maybe milestone Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zivkovicmilos zivkovicmilos zivkovicmilos approved these changes

Assignees

@moul moul

Labels
None yet
Projects
😎 Manfred's Board
Status: Done
🚀 The Launch
Archived in project
Milestone
💡Someday/Maybe
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@moul @zivkovicmilos