Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative link paths for the GNO website #459

Merged
merged 2 commits into from
Jan 16, 2023

Conversation

zivkovicmilos
Copy link
Member

Description

This PR simply modifies the HOME.md file in the gno website module to utilize relative link paths, instead of hardcoded link paths.

As pointed out in #458, spinning up a local version of the website will link to the testnet, and not the local running instance, on the homepage.

Additionally, a build step was added to the all directive in the Makefile, so existing READMEs are valid - the gnofaucet binary is not being built in the build folder, but the README on the faucet assumes it is.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist (for contributors)

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Deployed the website using the ./build/website command and checked that links are relative instead of absolute.

@zivkovicmilos zivkovicmilos added the 🐞 bug Something isn't working label Jan 16, 2023
@zivkovicmilos zivkovicmilos self-assigned this Jan 16, 2023
@zivkovicmilos zivkovicmilos requested a review from a team as a code owner January 16, 2023 14:52
@moul moul merged commit 2a65a8c into gnolang:master Jan 16, 2023
@zivkovicmilos zivkovicmilos deleted the feature/improve-website-links branch January 16, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants