Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tests): join directories files and files2 #535

Merged
merged 7 commits into from
Feb 27, 2023

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Feb 22, 2023

Some slight refactoring in tests/file.go to also make the code clearer in file_test.go (ie. make it clear in code that the difference is WithNativeLibs, which may be less obvious if this is through a boolean flag).

Merging the directories was done taking a look at git diff --no-index files files2, after a first inspection of the differing files by doing a sha1sum **/*.gno in each directory. For reference, here is the diff of sha sums in the two directories, highlighting extra and different files in each directory (- is files/, + is files2) together with a few comments on their effective differences.

In many cases, the differences are attributed to formatting differences in the time package. I'm not sure what is the full background on these, but in any case I kept doing any changes on them as outside of the scope of the PR.

In the new merged directory, where tests diverge or are specific to either stdlibs or native, they should contain _native or _stdlibs

@thehowl thehowl requested a review from a team as a code owner February 22, 2023 12:57
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 💯

It's much more cleaner now. I love the touch with the run options 👌

I've left a few small comments that we can discuss

tests/file_test.go Outdated Show resolved Hide resolved
tests/files/extern/net/http/http.gno Outdated Show resolved Hide resolved
@moul moul merged commit 3aa1d81 into gnolang:master Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

3 participants