refactor(tests): join directories files and files2 #535
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some slight refactoring in
tests/file.go
to also make the code clearer infile_test.go
(ie. make it clear in code that the difference isWithNativeLibs
, which may be less obvious if this is through a boolean flag).Merging the directories was done taking a look at
git diff --no-index files files2
, after a first inspection of the differing files by doing asha1sum **/*.gno
in each directory. For reference, here is the diff of sha sums in the two directories, highlighting extra and different files in each directory (- is files/, + is files2) together with a few comments on their effective differences.In many cases, the differences are attributed to formatting differences in the time package. I'm not sure what is the full background on these, but in any case I kept doing any changes on them as outside of the scope of the PR.
In the new merged directory, where tests diverge or are specific to either stdlibs or native, they should contain
_native
or_stdlibs