-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add unsafe (unencrypted) private key import / export functionality #537
feat: add unsafe (unencrypted) private key import / export functionality #537
Conversation
Hello @zivkovicmilos, currently adena supports Thanks to this pr, I think However we(adena) still need |
Hey @r3v4s, The import command with the |
Hey @zivkovicmilos Adena needs raw byte value to handle hex encoding, which means user need to upload file(or idk.. somehow pass raw value), i.e user can't just copy & paste result from |
Got it - just to understand, you would like to hex the private key armor as well? (not just the raw private key bytes) |
@zivkovicmilos nah |
@r3v4s I'll look into opening up a PR this week and tagging you to make sure we got the API right |
Description
Based on discussions with the Onbloc team, this PR introduces unsafe (unencrypted) private key export and import functionality to
gnokey
.Changes include
Checklist (for contributors)
Testing
Manual tests
--unsafe
flag.Additional comments
cc @r3v4-onbloc