Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix workflow typo in go-version matrix #547

Merged
merged 1 commit into from
Mar 1, 2023
Merged

chore: fix workflow typo in go-version matrix #547

merged 1 commit into from
Mar 1, 2023

Conversation

zivkovicmilos
Copy link
Member

@zivkovicmilos zivkovicmilos commented Feb 28, 2023 •
edited

Description

This PR fixes a typo in the workflow files that resulted in workflows being run on go 1.18, instead of the matrix versions.
The matrix version being queried in the workflow is go-version, instead of goversion.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist (for contributors)

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@zivkovicmilos zivkovicmilos added the 🐞 bug Something isn't working label Feb 28, 2023
@zivkovicmilos zivkovicmilos self-assigned this Feb 28, 2023
@zivkovicmilos zivkovicmilos requested a review from a team as a code owner February 28, 2023 12:43
thehowl
thehowl approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@thehowl thehowl changed the title chore: fix workflow typo chore: fix workflow typo in go-version matrix Mar 1, 2023
@moul moul merged commit b619582 into gnolang:master Mar 1, 2023
@zivkovicmilos zivkovicmilos deleted the fix/workflow-typo branch March 1, 2023 11:22
harry-hov pushed a commit to harry-hov/gno that referenced this pull request Mar 6, 2023
@zivkovicmilos @harry-hov
chore: fix workflow typo in go-version matrix (gnolang#547)
3cceae4
harry-hov pushed a commit to harry-hov/gno that referenced this pull request Mar 7, 2023
@zivkovicmilos @harry-hov
chore: fix workflow typo in go-version matrix (gnolang#547)
d70f873
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moul moul moul approved these changes

@thehowl thehowl thehowl approved these changes

@harry-hov harry-hov harry-hov approved these changes

Assignees

@zivkovicmilos zivkovicmilos

Labels
🐞 bug Something isn't working
Projects
🚀 The Launch
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zivkovicmilos @moul @thehowl @harry-hov