refactor(gnolang): remove unnecessary if-else #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thehowl
approved these changes
Mar 1, 2023
moul
approved these changes
Mar 1, 2023
|
@harry-hov do you plan to make additional ones? if yes, let's keep this PR open and merge regularly by batches. |
|
i.e., #551 |
|
@moul I'm not planning to work on an additional PR related to this. At least not this week. I was just going through the |
|
What about merging 551 into this one and keeping this meta PR open with all the style improvements you find by walking this package and merging it when you finish or on a weekly/bi-weekly basis? |
|
Sounds good to me. Will close 551. |
harry-hov
changed the title
…ve-unnecessary-else chore(gnolang/nodes_string): remove unnecessary else
harry-hov
changed the title
harry-hov
changed the title
…ove-unnecessary-else gnolang/values_string: remove unnecessary if-else
…ecessary-else gnolang/values: remove unnecessary if-else
|
Let's merge this one now, and feel free to open another one we keep open for a few days. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed unnecessary else blocks from
pkgs/gnolang.