fix(website): help page and ffcli arg/flags ordering #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffcli imposes to write all flags before arguments, the help page of the website binary wasn't updated accordingly.
zivkovicmilos
approved these changes
Mar 20, 2023
moul
approved these changes
Mar 21, 2023
Closed
r3v4s
pushed a commit
to r3v4s/gno
that referenced
this pull request
Mar 28, 2023
moul-bot
pushed a commit
that referenced
this pull request
Mar 28, 2023
peter7891
pushed a commit
that referenced
this pull request
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ffcliimposes to write all flags before arguments, the help page of the website binary wasn't updated accordingly.How has this been tested?
Try to run the command described in the
?helppage of a random realm. When it fails because offlag: help requested, that usually meansffclidoesn't accept the format because there's flags after arguments.Fix the command build in the JS code, by moving the argument at the very end, refresh and then ensure the command is running correctly.