chore: bcrypt cost adjustment #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the impact on performance? |
|
Do bcrypt's security measures have relevance to this situation? I'm more concerned about the potential risks of a weak PRNG than demonstrating proof of effort/work here. |
zivkovicmilos
approved these changes
Mar 29, 2023
|
Benchmarks with 12 cost Benchmarks with 11 cost |
moul
approved these changes
Mar 29, 2023
There was a problem hiding this comment.
I support merging this issue as it is both redundant and disruptive to development.
I suggest that we open an issue to further discuss the security concerns. We should consider using a single round of bcrypt or switching to a simpler hashing function for this particular case. If that is not feasible, then let's determine the best default values and add comments to explain our decisions.
grepsuzette
added a commit
to grepsuzette/gno
that referenced
this pull request
Apr 1, 2023
This reverts e0c50ec (gnolang#670) It breaks decoding of existing accounts. For instance if you addpkg, it gives: Enter password. ciphertext decryption failed Changing bcryptSecurityParameter = 12 (from 11) makes it work again. Better change until we find a better solution.
moul-bot
pushed a commit
to moul/gno
that referenced
this pull request
Apr 1, 2023
This reverts commit e0c50ec.
moul
pushed a commit
that referenced
this pull request
Apr 1, 2023
Co-authored-by: grepsuzette <grepsuzette@users.noreply.github.com>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we reduce the
bcryptcost from12to11.@zivkovicmilos expressed concerns that
CreateAccountwas too slow.It seems like this is safe to do. As far as i understand this refers to local storage.