Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove std.TestDerivePkgAddr #707

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

tbruyelle
Copy link
Contributor

@tbruyelle tbruyelle commented Apr 6, 2023

This function declared in the test native functions, can be superseded by std.DerivePkdAddr, which has been added afterward. The 2 functions share exactly the same code.

@tbruyelle tbruyelle requested a review from a team as a code owner April 6, 2023 13:59
@tbruyelle tbruyelle changed the title chore: remove std.TestDerivePkgAddr chore: remove std.TestDerivePkgAddr Apr 6, 2023
This function declared in the test native functions, can be
subserseded by std.DerivePkdAddr, which has been added afterward.
The 2 functions shares exactly the same code.
@tbruyelle tbruyelle force-pushed the chore/remove-TestDerivePkgAddr branch from 5251347 to 4c047f1 Compare April 6, 2023 14:03
Copy link
Member

@moul moul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I forgot to GC.

@moul moul merged commit 0eb5ff7 into gnolang:master Apr 6, 2023
40 checks passed
@tbruyelle tbruyelle deleted the chore/remove-TestDerivePkgAddr branch April 6, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants