fix(gnolang): duplicate field name in struct literal #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix gnolang#629 The following code returns an error in go, but not in gno: ```go type s struct { f int } s{f:1, f:2} ``` The change detects a field has already been set in a struct literal and panics. Note that unlike go code, the parsing stops at the first duplicate field met, whereas in go all the duplicate fields are mentionned in the error. See go playground link: https://go.dev/play/p/byJwYsIETBU
moul
approved these changes
Apr 6, 2023
thehowl
approved these changes
Apr 18, 2023
There was a problem hiding this comment.
This is good. However I made a test and seems like this error is not caught also on maps (ie.
m := map[string][]Foo{
"hello": {Foo{"foo"}, Foo{"bar"}},
"world": {Foo{"truc"}, Foo{"machin"}},
"hello": {},
}does not return an error), and I imagine probably array/slices as well.
Shall we address them all in one PR (as they are essentially the same bug), or do you want to tackle this in a different PR?
@tbruyelle up to you. |
|
Good catch @thehowl ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #629
Description
The following code returns an error in go, but not in gno:
The change detects a field has already been set in a struct literal and panics.
Note that unlike go code, the parsing stops at the first duplicate field met, whereas in go all the duplicate fields are mentionned in the error.
See go playground link: https://go.dev/play/p/byJwYsIETBU
How has this been tested?
A new testfile has been added.