Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use std.PrevRealm() in grc20 and grc721 #895

Merged
merged 2 commits into from
Jul 4, 2023

Conversation

albttx
Copy link
Member

@albttx albttx commented Jun 14, 2023

Description

following #667 update grc20 and grc721 implementation to use std.PrevRealm rather than std.GetOrigCaller

@albttx albttx requested a review from a team as a code owner June 14, 2023 15:10
@albttx albttx self-assigned this Jun 14, 2023
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Jun 14, 2023
Copy link
Contributor

@tbruyelle tbruyelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin' good 💯

@albttx
Copy link
Member Author

albttx commented Jul 3, 2023

last review please @moul 🙏🏼

Copy link
Member

@moul moul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for majority of cases.

For the edge cases, I think we’ll need to document how to bypass this general case later.

@moul moul merged commit 2b2156f into gnolang:master Jul 4, 2023
29 checks passed
Doozers pushed a commit to Doozers/gno that referenced this pull request Aug 31, 2023
moul added a commit that referenced this pull request Sep 22, 2023
update (missing part of) grc721 package implementation to use
`std.PrevRealm()` not `std.GetOrigCaller()`

## related
#667 implementation of `std.PrevRealm()`
#895 update grc20, 721 to use `std.PrevRealm()`

<details><summary>Checklists...</summary>

## Contributors Checklist

- [x] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](../.benchmarks/README.md).
</details>

Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
gfanton pushed a commit to gfanton/gno that referenced this pull request Nov 9, 2023
update (missing part of) grc721 package implementation to use
`std.PrevRealm()` not `std.GetOrigCaller()`

## related
gnolang#667 implementation of `std.PrevRealm()`
gnolang#895 update grc20, 721 to use `std.PrevRealm()`

<details><summary>Checklists...</summary>

## Contributors Checklist

- [x] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](../.benchmarks/README.md).
</details>

Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: 🚀 Needed for Launch
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants