feat: add r/demo/showcase #898
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🧾 package/realm
moul
commented
Jun 16, 2023
| @@ -612,6 +612,7 @@ func (m *Machine) Eval(x Expr) []TypedValue { | |||
| m.PushOp(OpHalt) | |||
| m.PushExpr(x) | |||
| m.PushOp(OpEval) | |||
| defer m.injectLocOnPanic() | |||
There was a problem hiding this comment.
@jaekwon, any particular reason for not doing this?
This was referenced Jun 16, 2023
Merged
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
also updated `app.css` to visualy handle nested bullet list Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
gfanton
force-pushed
the
dev/moul/showcase
branch
from
0a9a173
to
7dfaeeb
Compare
github-actions
bot
added
the
📦 ⛰️ gno.land
gfanton
force-pushed
the
dev/moul/showcase
branch
2 times, most recently
from
0d5fa84
to
761f25a
Compare
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
gfanton
force-pushed
the
dev/moul/showcase
branch
from
761f25a
to
ae3f4d2
Compare
|
also, I think we gonna have a lot of exposed Methods in this package, it should be cool to have something similar to the golang documentation, indexing all the Exposed methods on the [help] page, something like this: or maybe in another PR ? |
moul
commented
Aug 10, 2023
|
|
||
| ul > li > ul { | ||
| padding-left: 1rem; | ||
| list-style: circle inside; |
There was a problem hiding this comment.
cc @alexiscolin: I think this is a good bugfix, but since you're working on the same file on your PR #781; please make a quick review.
There was a problem hiding this comment.
Yes, nice UX improvement for nested unordered lists! 👍
alexiscolin
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #902
Depends on #885
bf(feat: add p/demo/bf (brainfuck vm) #885)svg(feat: add p/demo/svg #905)ui(chore: refactor p/demo/ui #902)Contributors Checklist
BREAKING CHANGE: xxxmessage was included in the descriptionMaintainers Checklist
CONTRIBUTING.mdBREAKING CHANGE:in the body)