Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(make): make lint work without installing golangci-lint #951

Merged
merged 2 commits into from
Jul 6, 2023
Merged

chore(make): make lint work without installing golangci-lint #951

merged 2 commits into from
Jul 6, 2023

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Jul 5, 2023

also updated golangci-lint to 1.53 because things kept breaking if I tried to lock the version at 1.51 in the deps. so much for good dependency management...

Checklists...

Contributors Checklist

  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

Maintainers Checklist

  • Checked that the author followed the guidelines in CONTRIBUTING.md
  • Checked the conventional-commit (especially PR title and verb, presence of BREAKING CHANGE: in the body)
  • Ensured that this PR is not a significant change or confirmed that the review/consideration process was appropriate for the change

@thehowl thehowl added the 🌟 improvement performance improvements, refactors ... label Jul 5, 2023
@thehowl thehowl self-assigned this Jul 5, 2023
@thehowl thehowl requested a review from a team as a code owner July 5, 2023 16:01
@github-actions github-actions bot added 📦 🤖 gnovm Issues or PRs gnovm related 📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Jul 5, 2023
moul
moul reviewed Jul 6, 2023
View reviewed changes
Makefile Show resolved Hide resolved
@thehowl thehowl merged commit 0307b8a into gnolang:master Jul 6, 2023
61 checks passed
@thehowl thehowl deleted the morgan/golangci-devdeps branch July 10, 2023 16:49
Doozers pushed a commit to Doozers/gno that referenced this pull request Aug 31, 2023
@thehowl @Doozers
chore(make): make lint work without installing golangci-lint (gnolang…
65f9912 
…#951)

* chore(make): make lint work without installing golangci-lint

* xx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moul moul moul approved these changes

Assignees

@thehowl thehowl

Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related 🌟 improvement performance improvements, refactors ...
Projects
TM2/GnoVM
Status: Done
🚀 The Launch
Status: 🔵 Not Needed for Launch
🧐 Review Meeting
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thehowl @moul