Add ability to configure cell width (font character spacing) #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we have a setting for changing the line height (cell height), but not for changing cell width (both available in VTE). Depending on the font used, it is useful to have the ability to set a little more space between characters. This commit adds a configuration similar to the existing one for line height, but for character space (cell width scale [1]). Thanks Matt Rose for helping and encouraging me to implement this. 1. https://lazka.github.io/pgi-docs/Vte-2.91/classes/Terminal.html#Vte.Terminal.set_cell_width_scale
FernandoBasso
force-pushed
the
feat/configure-cell-width
branch
from
232fb5f
to
d7cc276
Compare
|
@FernandoBasso See Gitter for feedback on this. There's a few issues that need fixing before I can pull. |
FernandoBasso
force-pushed
the
feat/configure-cell-width
branch
from
d7cc276
to
1c2ba97
Compare
After the previous commit [1], which implements ‘cell width’, it makes sense to rename ‘line height’ to ‘cell height’, especially because it is the terminology used by VTE itself [2]. 1. ef17685 Add cell width configuration in preferences 2. https://lazka.github.io/pgi-docs/Vte-2.91/classes/Terminal.html#Vte.Terminal.set_cell_height_scale
FernandoBasso
force-pushed
the
feat/configure-cell-width
branch
from
1c2ba97
to
bd5dba5
Compare
|
@mattrose Just pushed an amend to the last commit based on your suggestions. Thanks once again for all the support. |
|
Looks good, thank you! Sorry to be such a pain on this one, and sorry to be so long in looking this over, I've just been quite busy lately. |
No problem at all. Thanks again for all the support @mattrose. |
This was referenced Feb 16, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terminator already implements the VTE “cell height” feature. This PR implements “cell width”.
We also take the opportunity to refactor “line height“ to “cell height“ to match VTE terminology and to avoid having to related, similar features with two different naming style in the code base.
Thanks @mattrose for the help and encouragement <3.