New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: handle_size treated as cell_width #561

Merged

mattrose merged 2 commits into gnome-terminator:master from Vulcalien:cell-width-preferences

Dec 26, 2021

Member

Vulcalien commented Dec 25, 2021

In PR #552 the cell_width setting was introduced.
However, the GUI has a bug that makes the handle_size be considered as cell_width.

To reproduce:

open preferences
change the value of 'Terminal separator size' all the way left and then all the way right
the 'Cell Width' setting is changing too

I also moved "Cell Height" after "Cell Width", so that we have "width, height" instead of "height, width".

Vulcalien added 2 commits

December 25, 2021 13:09


          Fix: handle_size treated as cell_width

eacd721


          Move 'cell_height' setting

3c57502

Contributor

FernandoBasso commented Dec 26, 2021

@Vulcalien Thanks a lot for spotting the problem and the fixing it! Awesome!

mattrose merged commit ca335e4 into gnome-terminator:master

Vulcalien deleted the cell-width-preferences branch

December 27, 2021 10:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment