Skip to content

Commit

Permalink
fixed nasty content-length bug.
Browse files Browse the repository at this point in the history
apparently rails needs "CONTENT_LENGTH" key in the environ instead of "HTTP_CONTENT_LENGTH"?  the ragel parser is currently hitting content-length headers twice - this is a know bug and mearly an annoyance. I plan on working more with the parser soon so I'll leave the bug in for the 0.1.0 release.
  • Loading branch information
Ryan Dahl committed Mar 18, 2008
1 parent 4c5b762 commit 0a8a18b
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
8 changes: 5 additions & 3 deletions README
Original file line number Diff line number Diff line change
Expand Up @@ -102,14 +102,16 @@ buffer is set at 40 kilobytes before it writes to file.

## Contributions

Contributions (patches, criticism, advice) are very welcome! The source code
Contributions (patches, criticism, advice) are very welcome!
All should be posted to http://groups.google.com/group/ebbebb or emailed to me.

The source code
is hosted [github](http://github.com/ry/ebb/tree/master). It can be retrieved
by executing

git clone git://github.com/ry/ebb.git

I intend to keep the C code base very small, so do email me before writing any
large additions. Here are some features that I would like to add:
Here are some features that I would like to add:
* HTTP 1.1 Expect/Continue (RFC 2616, sections 8.2.3 and 10.1.1)
* A parser for multipart/form-data
* Optimize and clean up upload handling
Expand Down
2 changes: 1 addition & 1 deletion ruby_lib/ebb/runner.rb
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ def run(argv)
Ebb.log.print("Ebb is loading the application...")
Ebb.log.flush()
@app = app(@options)
Ebb.log.puts("loaded")
Ebb.log.puts("done")

if @options[:daemonize]
pwd = Dir.pwd # Current directory is changed during daemonization, so store it
Expand Down
2 changes: 1 addition & 1 deletion src/ebb_ruby.c
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ void Init_ebb_ext()
DEF_GLOBAL(request_body, "REQUEST_BODY");
DEF_GLOBAL(server_port, "SERVER_PORT");
DEF_GLOBAL(path_info, "PATH_INFO");
DEF_GLOBAL(content_length, "HTTP_CONTENT_LENGTH");
DEF_GLOBAL(content_length, "CONTENT_LENGTH");
DEF_GLOBAL(http_host, "HTTP_HOST");

rb_define_singleton_method(mFFI, "server_process_connections", server_process_connections, 0);
Expand Down

0 comments on commit 0a8a18b

Please sign in to comment.