This repository has been archived by the owner on Apr 4, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
Moving helper functions from dex-react
#69
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
import { AssertionError } from 'assert' | ||
|
||
export function assert<T>(val: T, message: string): asserts val is NonNullable<T> { | ||
if (!val) { | ||
throw new AssertionError({ message }) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,19 @@ | ||
import { MAX_BATCH_ID } from 'const' | ||
|
||
/** | ||
* Epoch in seconds | ||
*/ | ||
export function getEpoch(): number { | ||
return Math.floor(Date.now() / 1000) | ||
} | ||
|
||
/** | ||
* Checks whether batchId is `never expires` | ||
* Using the convention which the fronted creates orders with expiration date set | ||
* to max uint32 when placing orders active indefinitely. | ||
* | ||
* @param batchId The expiration batch id to check | ||
*/ | ||
export function isNeverExpiresOrder(batchId: number): boolean { | ||
return MAX_BATCH_ID === batchId | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't exactly a NonNullable assertion, though it may be ok for our purposes
!val
will break on every falsy value (0, ''
)https://www.typescriptlang.org/docs/handbook/utility-types.html#nonnullablet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any suggestion on how to fix this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can do sth like
val ?? somethingElse
where0
and''
will be accepted but nothing elsenullish coalescense or sth similar in TS 3.7+