This repository has been archived by the owner on Apr 4, 2022. It is now read-only.
Moving helper functions from dex-react
#69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 24, 2020
Velenir
approved these changes
Jan 24, 2020
| import { AssertionError } from 'assert' | ||
|
|
||
| export function assert<T>(val: T, message: string): asserts val is NonNullable<T> { | ||
| if (!val) { |
There was a problem hiding this comment.
This isn't exactly a NonNullable assertion, though it may be ok for our purposes
!val will break on every falsy value (0, '')
https://www.typescriptlang.org/docs/handbook/utility-types.html#nonnullablet
There was a problem hiding this comment.
Any suggestion on how to fix this?
There was a problem hiding this comment.
you can do sth like val ?? somethingElse where 0 and '' will be accepted but nothing else
nullish coalescense or sth similar in TS 3.7+
anxolin
approved these changes
Jan 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of gnosis/gp-v1-ui#436
Moving helper functions from
dex-react:assertisNeverExpiresOrder