Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

436/is order unlimited #111

Merged
merged 7 commits into from
Jan 27, 2020
Merged

436/is order unlimited #111

merged 7 commits into from
Jan 27, 2020

Conversation

alfetopito
Copy link
Contributor

Part of gnosis/gp-v1-ui#436

Requires gnosis/dex-js#67 and gnosis/dex-js#69 to be published.

WARNING

  • Not able to test locally. My local setup did not work :(
  • Lots of noise due to linter changes.

@alfetopito alfetopito self-assigned this Jan 24, 2020
anxolin
anxolin approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I also like that you moved the message logic to a helper :)

@anxolin
Copy link
Contributor

anxolin commented Jan 27, 2020

I assume Travis is not passing because of the "WARNING" in the description

@Velenir Velenir merged commit 1e617cc into develop Jan 27, 2020
@alfetopito alfetopito deleted the 436/isOrderUnlimited branch January 27, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anxolin anxolin anxolin approved these changes

@Velenir Velenir Awaiting requested review from Velenir

@W3stside W3stside Awaiting requested review from W3stside

Assignees

@alfetopito alfetopito

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alfetopito @anxolin @Velenir