Skip to content
This repository has been archived by the owner on Feb 18, 2020. It is now read-only.

David-Feature: Adding FE Migration Scripts + clean up #38

Merged
merged 6 commits into from
Feb 12, 2019
Merged

David-Feature: Adding FE Migration Scripts + clean up #38

merged 6 commits into from
Feb 12, 2019

Conversation

W3stside
Copy link
Contributor

@W3stside W3stside commented Feb 12, 2019 •
edited
Loading

  1. Adds src/migrations/ to root holding migrations logic separated from main migrations (as dx-contracts does and allows FE to pull in deps + migrate/compile contracts outside the main repo)
  2. Clean up on 4_deploy_pool logic
  3. Pinned dx-contracts util-contracts gno-token to versions 2.0.0, respectively

@W3stside
eslint edits
f70ec08
@W3stside
added .history to .gitignore
f2f9bc9
@W3stside
pinned dx-contract, util-contracts, gno-token to 2.0.0
65141cc
@W3stside
created DxMgnPoolDepsGetter contract
cb836c6
@W3stside
created a separate fe_migrations folder holding migration logic
a2e5a9b 
1. allows FE to pull one migration file and use easily
2. modularizes migration code mirroring dx-contracts migration logic
3. cleaned up 4_deploy_pool logic
@W3stside
Copy link
Contributor Author

eslint edits I made as I was annoyed of squigly red lines but lemme know if you'd like me to revert them; I think it's just an add for recognizing process from node (not sure why it's not recognized on my IDE in your repo)

@fleupold
Copy link
Contributor

What exactly does FE mean?

josojo
josojo suggested changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@josojo josojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks David,
you rock
Only the naming of the folder should be similar to our other projects

@W3stside
changed fe_migrations folder to src/migrations
42f92cc 
- matches dx-contracts and other @gnosis.pm fs naming scheme
@W3stside
Copy link
Contributor Author

donezo! 👍 @fleupold it's frontend but in this case it wasn't really frontend specific at all 😅

josojo
josojo approved these changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@josojo josojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

fleupold
fleupold approved these changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@fleupold fleupold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@W3stside
Copy link
Contributor Author

W3stside commented Feb 12, 2019 •
edited
Loading

I'll let you guys merge 👍 Could someone RC2 and publish? Thanks 😃

@josojo josojo merged commit 5c54c9c into master Feb 12, 2019
@fleupold fleupold deleted the david-feature/FE_Migration_Scripts branch February 13, 2019 10:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fleupold fleupold fleupold approved these changes

@josojo josojo josojo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@W3stside @fleupold @josojo