Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving 2FA confirm card #186

Closed
fairlighteth opened this issue May 23, 2019 · 4 comments
Closed

Consider moving 2FA confirm card #186

fairlighteth opened this issue May 23, 2019 · 4 comments

Comments

@fairlighteth
Copy link

Challenge/problem:

  • Right now on transaction screens (Send Funds, Incoming transaction request) a lot of space is taken up by the 2FA confirmation card. Depending on the device height/resolution this will force the user to have to scroll to see the rest of the view.

Screen Shot 2019-05-23 at 17 11 43

Proposed solution:

In general a lot of information is shown in the review screen. The review screen I consider a good practice in itself, allowing the user to oversee what they're about to send/confirm. Instead of showing the 2FA confirm card upfront, we could break down the flow by showing the review first, have the user tap on 'Submit' and then show a bottom action sheet/card with the 2FA request.

Screen Shot 2019-05-23 at 17 16 04Screen Shot 2019-05-23 at 17 36 02

In my opinion this doses the amount of information, especially on the review screen.

@posthnikova
Copy link

We can dose information not by breaking it into separate screens but by adding animated transitions (example https://dribbble.com/shots/6372790-Coffee-Ordering-Animation-Starbucks).
I would not overlay details about transaction. I would collapse them instead and make them react to scroll (example here https://dribbble.com/shots/2367675-Ticket-scroll).
This bottom sheet could make the top part collapse like here https://storage.googleapis.com/spec-host-backup/mio-design%2Fassets%2F10oN2rj2F4Ju3jJUg6wFCRqA_G5TsWQUm%2Fbehavior-visibility-standard.mp4. I assume Confirmed and Rejected states are also shown on this bottom sheet.

@fairlighteth
Copy link
Author

Thanks for the examples.

The collapse/react to scroll, would still mean the user would have to scroll to see all content. Also it would hide the 2FA confirmation dialog (at least partially).

I like the examples you showed, but not convinced they're solving the initially reported challenge. Otherwise we can iterate on ideas with mockups, as that's probably the best way to test the look and feel of it.

@lukasschor
Copy link
Member

I would revisit this topic as part of the 2FA Integration when we tackle the Send flow screens. Do you agree @tschubotz? If yes, should we close this ticket?

@tschubotz
Copy link
Member

Hmm. I would not do this as part of the 2FA ticket to keep complexity low tbh. I would leave it in this design backlog. Or we move it to "Not now" if you think it clutters it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants