Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move whereami into a submodule #1484

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

slayoo
Copy link
Member

@slayoo slayoo commented Jan 18, 2023

No description provided.

@alaingdl
Copy link
Contributor

seems to have problems here :

CMake Error at src/CMakeLists.txt:200 (add_library):
  Cannot find source file:

    /home/alaingdl/GDL/TestPR1484/gdl/src/whereami/src/whereami.c

  Tried extensions .c .C .c++ .cc .cpp .cxx .cu .m .M .mm .h .hh .h++ .hm
  .hpp .hxx .in .txx


CMake Error at src/CMakeLists.txt:200 (add_library):
  No SOURCES given to target: whereami

@GillesDuvert
Copy link
Contributor

@alaingdl this is looks like an old error during an early phase of the patch. gdl/src/whereami/src does not exist. Perhaps a line inadvertly forgotten in CMakeFiles. I'll check.
@slayoo This is typically what is going to happen if we use submodules.

@GillesDuvert
Copy link
Contributor

Ok, works with last @slayoo change.
So we have now a submodule. Good first example.

@GillesDuvert GillesDuvert merged commit 4374f57 into gnudatalanguage:master Jan 18, 2023
Copy link
Contributor

@GillesDuvert GillesDuvert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK!!!

@GillesDuvert
Copy link
Contributor

NOK!!
The whereami @ ba364cdi folder is not propagated to a clone made or managed by NetBeans!!!

@GillesDuvert
Copy link
Contributor

OK, this has to be done manually. By removing the cloned gdl, replacing it with the command
git clone --recursive https://github.com/gnudatalangage/gdl.git
Then more or less have Netbeans refresh its paths and files by resetting the "Source Folder" in the project (sufficed in my case).

@alaingdl
Copy link
Contributor

(this command is not working here, I have to make :
git clone --recursive https://github.com/gnudatalanguage/gdl/ )

OK, now works for me with this --recursive, the previous was NOK (u22.04)
TBC on OSX ASAP.

@slayoo
Copy link
Member Author

slayoo commented Jan 18, 2023

@alaingdl @GillesDuvert when a new submodule is added on GitHub and you update your local clone, git does not by default obtain submodule contents - just metadata. Instead of re-cloning with the --recursive option, one can also use git submodule update or do git pull --recurse-submodules as described here (https://git-scm.com/book/en/v2/Git-Tools-Submodules#_pulling_upstream_changes_from_the_project_remote):
image

@alaingdl
Copy link
Contributor

heeuuu, don't work for me (on Debian 10.13; git version 2.20.1)

@slayoo
Copy link
Member Author

slayoo commented Jan 19, 2023

heeuuu, don't work for me (on Debian 10.13; git version 2.20.1)

@alaingdl, please elaborate

@alaingdl
Copy link
Contributor

Sorry. I tried both commands you mentioned (git submodule update or do git pull --recurse-submodules), on a clean git pull version, but when I try to compile, I got the same error message as before (may be I made a mistake)

@slayoo
Copy link
Member Author

slayoo commented Jan 19, 2023

@alaingdl, please try git submodule update --init

@alaingdl
Copy link
Contributor

Thanks, yes, git submodule update --init is working. And git clone --recurse-submodules https://github.com/gnudatalanguage/gdl too.

We have to document that somewhere because the basic commands are no more enough to got it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants