-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shmmap etc #1703
Shmmap etc #1703
Conversation
Thanks @GillesDuvert !!! |
@GillesDuvert wouhaouh I cannot compile on Debian due to relic from the saverestore redefinition of xdr_u_int32_t I cannot link on OSX :
But I can compile & test on u2204 ! And the demo provided by @brandy125 is working find for /long and /double ! (but I succeed to crash by after to another local variable the same global one) |
Conflicts: src/CMakeLists.txt
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1703 +/- ##
==========================================
- Coverage 42.01% 41.92% -0.09%
==========================================
Files 359 361 +2
Lines 96161 96379 +218
Branches 19747 19817 +70
==========================================
+ Hits 40401 40410 +9
- Misses 55760 55969 +209 ☔ View full report in Codecov by Sentry. |
The support is very minimal and risky: there is no mechanism to avoid collisions, the detaching and destroying of shared areas is unsafe at best. @brandy125 for serious work and for the time being you need to have only one process writing and all the others reading. Incidentally, this is a way to share data with IDL as the memory mapping of simple arrays is the same. |
…mapped memory when destroyed. probably better to replace all that by a simpler variant of the Assoc mechanism, but the use of a DPtrGDL here permits to get the memory cleaned when the referenc count drops to zero.
On u2204 and Debian 10, I can reproduce most of the problems in Codecov :
|
Indeed, last hack had a flaw. Corrected. There will be a possibility of memory leak for rare cases until I set up a better scheme, but this will need a change in the BaseGDL objects. |
@GillesDuvert tested with success on x86_64 for Debian10, u2204 and OSX 12.3 BUT on OSX I need to remove "-lrt" in src/CMakeFiles/gdl.dir/link.txt to got the link no more crash. Once the small problem on OSX fixed, I vote for a merge ! |
…map list, correct handling of pending delete shared memory and offsets.
@GillesDuvert Linked perfectly on OSX 12.3 ! Still linking on Debian 12 ;) All tests OK on both :) It is a GO for me for a 1.0.5 ! |
…rocesses (memory flush needed?)
OK, probably quite complete. Windows support should be easy afterwards. |
WIP but can be tested