Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable cleaning of internal gdl objects at exit in debug mode #1762

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

GillesDuvert
Copy link
Contributor

if gdl is compiled with -DCMAKE_CXX_FLAGS='-DGDL_DO_ATEXIT=1 ...' , i.e, if GDL_DO_ATEXIT is defined, then gdl will clean up all its objects before exit.
This removes a tremendous list of supposed memory leaks as reported by Valgrind or Sanitizers.
To be used in debug mode of course.
Mostly, with the exception of a small list of internal objects that cannot be destroyed before exit (because they share memory with another, destroyed, object) the (still long) list of supposed memory leaks is dues to wxWidgets or other external libraries (probably beacause we do not correctly use their respective cleanup functions).

…XIT=1 ...' , i.e, if GDL_DO_ATEXIT is defined, then gdl will clean up all its objects before exit. this removes a tremendous list of supposed memory leaks as reported by Valgrind or other sanitizers. To be used in debug mode of course.
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.83%. Comparing base (e11536c) to head (463cf32).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1762   +/-   ##
=======================================
  Coverage   42.83%   42.83%           
=======================================
  Files         361      361           
  Lines       97064    97060    -4     
  Branches    19850    19849    -1     
=======================================
- Hits        41577    41576    -1     
+ Misses      55487    55484    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GillesDuvert GillesDuvert merged commit 3672882 into gnudatalanguage:master Feb 29, 2024
8 checks passed
@GillesDuvert GillesDuvert deleted the cleanup_at_exit branch July 2, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant