Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fractional_resampler is a misnomer, should be renamed in next #1428

Closed
marcusmueller opened this issue Aug 16, 2017 · 1 comment
Closed

fractional_resampler is a misnomer, should be renamed in next #1428

marcusmueller opened this issue Aug 16, 2017 · 1 comment

Comments

@marcusmueller
Copy link
Member

marcusmueller commented Aug 16, 2017

The blocks that we call fractional_resampler_{cc|ff} really shouldn't be called "fractional", as it suggests a rational in/output rate ratio. That's explicitly not the case with these. We have rational_resampler_ for that!

This has caused a lot of confusion among students, and newbies, in general. I'm not excluding myself here.

It's clear how that name "happened" – we have a (slightly confusingly named, but still in range of sensibility) fractional_interpolator. The fractional_resampler is basically the same thing.

I propose: we call that mmse_arb_resampler, to use the same naming logic than for pfb_arb_resampler and list them as "MMSE arbitrary resampler" in GRC.

Renaming the fractional_interpolator to mmse_interpolator would make sense, too.

@jmcorgan
Copy link
Contributor

Agree. A PR to do this and change the QA, examples, and docs would be appreciated.

carlesfernandez added a commit to carlesfernandez/gnss-sdr that referenced this issue Feb 3, 2018
Following its renaming in GNU Radio 3.8 (see gnuradio/gnuradio#1428)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants