[Backport] gr-uhd/lib/usrp_block_impl.cc: fix compile error using boost>=1.73 #4005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using boost>=1.73 and compile with uhd, it always have errors. Fix the compile error when using uhd and gcc10: error: ‘_1’ was not declared Bug: https://bugs.gentoo.org/751259 usrp_source_impl.cc: use lambdas instead of boost::bind usrp_block_impl.cc:use lambdas instead of boost::bind usrp_block_impl.h: Switch from boost::function to std::function gnuradio#3441 gnuradio#3887 usrp_source_impl: fix parameter bug of original code The usrp_block_impl::register_msg_cmd_handler uses cmd_handler_t as handler type, but it have 3 parameters. Fix the parameter mismatch bug and change the signature as cmd_handler_t Signed-off-by: Huang Rui <vowstar@gmail.com>
marcusmueller
approved these changes
Dec 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using boost>=1.73 and compile with uhd, it always have errors.
Fix the compile error when using uhd and gcc10: error: ‘_1’ was not declared
Bug: https://bugs.gentoo.org/751259
usrp_source_impl.cc: use lambdas instead of boost::bind
usrp_block_impl.cc:use lambdas instead of boost::bind
usrp_block_impl.h: Switch from boost::function to std::function
#3441
#3887
usrp_source_impl: fix parameter bug of original code
The usrp_block_impl::register_msg_cmd_handler uses cmd_handler_t as
handler type, but it have 3 parameters.
Fix the parameter mismatch bug and change the signature as cmd_handler_t
Signed-off-by: Huang Rui vowstar@gmail.com