-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
digital: fix yaml and bindings for constellation #4018
Conversation
Still getting an error here.
|
@mormj Also, you forgot to sign-off your commit. |
@drmpeg - the |
That fixes the error, but makes the https://github.com/gnuradio/gnuradio/blob/master/gr-digital/python/digital/generic_mod_demod.py#L147 to: self._blocks += [self.chunks2symbols] And then look at the output of the constellation modulator block with a QT GUI Constellation Sink or use a File Sink and look at the file with a hex editor (ghex shows floating point values). |
Signed-off-by: Josh Morman <jmorman@perspectalabs.com>
@drmpeg - this should be fixed now - and changed the type to raw so that the stringifying is not done in the value field (and put normalization back on there). Question though that may warrant a separate PR - the standard constellation types - QPSK, 16-QAM, etc. don't expose the normalization options - should they pass through the normalization as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now.
From reading the original PR #2771, I don't think so. |
Adds implicit conversion to the enum type
Cleans up the binding code a bit (remove some dead code)
Change the dropdown from int to enum (as in other places)
Fixes #4007