Qt5 and python3 fixes for filter_design.py #4037
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was broken, this fix works. @samGNSS look at "Details" on the DCO check, failed due to lack of signature. |
samGNSS
force-pushed
the
filter_design_files
branch
2 times, most recently
from
f90e72a
to
049c8db
Compare
Signed-off-by: Sam Schmidt <samuel.schmidt.ee@gmail.com>
samGNSS
force-pushed
the
filter_design_files
branch
from
049c8db
to
ee224ce
Compare
marcusmueller
approved these changes
Jan 6, 2021
|
Merged manually (fixed commit subject line). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saving and reading CSV files from the filter design tool seems to have broken during the transition from Qt4 to Qt5. These changes are a quick and easy fix.