-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove MSVC shim header cruft, reduce CMake overhead #4104
Remove MSVC shim header cruft, reduce CMake overhead #4104
Conversation
c88ce5a
to
566d791
Compare
566d791
to
ac76ed6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to my eye, with the caveat that additionally you'll need to remove add_definitions(-DHAVE_CONFIG_H)
from CMakeLists.txt
to get it compiling! A conda build using these changes compiles successfully with MSVC (and on Linux and macOS).
Signed-off-by: Marcus Müller <mmueller@gnuradio.org>
ac76ed6
to
4f4657a
Compare
Signed-off-by: Marcus Müller <mmueller@gnuradio.org>
6c9b817
to
ecdfe68
Compare
I've removed the CMake Check cleanup, which is a separate issue (and now in #4256), and added in -DHAVE_CONFIG_H |
Introduces new warnings:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please fix the compiler warnings -- we no do -Werror
where applicable.
9abf6d9
to
f15ec42
Compare
Signed-off-by: Josh Morman <jmorman@perspectalabs.com>
f15ec42
to
9e636b4
Compare
Maybe merge the fixup UDP commit with the first one? |
Merged manually + squashed. |
closes #1680, closes #1674