blocks_runtime: create aliases for type encoding getters #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add _Block_has_signature() and _Block_signature() alises for calls to
block_getType_np() for increased compatibility with other
implementations of libobjc2.
Reasoning: WebKit uses private libobjc APIs like
_Block_signature
to do whatblock_getType_np
does, and requires them to be available.Actually, adding these macros still wouldn't make that part of WebKit fully compatible with libobjc2, since WK actually expects
_Block_signature
to be an undeclared exported symbol in libobjc (it redeclares the function as anextern
in its own code, which would fail compilation under the changes in this pull request). But reproducing these conditions in libobjc2 just wouldn't make any sense.However, having this alias in libobjc2 still seems like it could serve to improve compatibility between libobjc2 and Apple's libobjc – although I don't know if the project has previously made a decision to ignore parity with private APIs. In this case, I'll understand if the pull request is rejected and will move these changes to my GNUstep-compatible fork of WebKit.