digitalocean: configurable base URL #1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rienafairefr
changed the title
|
Hello, why do you want to proxy the calls to DigitalOcean API made for DNS ACME challenge? |
|
I'm experimenting with limiting token disclosure risk by passing API calls through a passthrough proxy (similar to https://github.com/google/magic-github-proxy). This way I could put another token somewhere that would be allowed to do the necessary calls for an acme challenge on a certain domain, and not a iota more. |
|
I could workaround using a more custom provider I think (like the httpreq), but I figured I could send the PR either way, some providers here have a customizable base_url. |
2 tasks
ldez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to proxy the calls to DigitalOcean API made for dns ACME challenge, and the go-acme/lego
digitaloceanprovider has hardcoded https://api.digitalocean.com, this PR should handle that hopefully.