Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DNS provider for "HTTP request". #710

Merged
merged 4 commits into from
Nov 9, 2018
Merged

Conversation

ldez
Copy link
Member

@ldez ldez commented Nov 8, 2018

The server must provide:

  • POST /present
  • POST /cleanup

The URL of the server must be define by HTTPREQ_ENDPOINT.

Mode

There are 2 modes (HTTPREQ_MODE):

  • default mode:
{
  "fqdn": "_acme-challenge.domain.",
  "value": "LHDhK3oGRvkiefQnx7OOczTY5Tic_xZ6HcMOc_gmtoM"
}
  • RAW
{
  "domain": "domain",
  "token": "token",
  "keyAuth": "key"
}

Authentication

Basic authentication (optional) can be set with some environment variables:

  • HTTPREQ_USERNAME and HTTPREQ_PASSWORD
  • both values must be set, otherwise basic authentication is not defined.

Additional information

Thanks to @mdbraber.
Related to #708

@mdbraber
Copy link
Contributor

mdbraber commented Nov 8, 2018

I've been trying to figure out if I can actually push to an unmerged PR I don't own, but I don't think I can?

Anyway: you've got "client" in places where it should say "present" (in the README). Also, I'd change the fqdn example to say '_acme-challenge.domain.tld.' to make it look less like an unqualified domainname.

(P.S. if you can explain if I could push these changes I'd be happy to do so if you can explain how ;-)

@ldez
Copy link
Member Author

ldez commented Nov 8, 2018

You cannot push on PR because you are not a maintainer, but you can do a review.

@ayang64
Copy link
Contributor

ayang64 commented Nov 9, 2018

Checks out.

@ayang64 ayang64 merged commit fac6e49 into go-acme:master Nov 9, 2018
@ldez ldez deleted the feature/httpreq branch November 9, 2018 11:55
@ldez ldez added this to the v2.0 milestone Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants